Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix coldcard build #756

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

ci: fix coldcard build #756

wants to merge 1 commit into from

Conversation

brunoerg
Copy link
Contributor

@brunoerg brunoerg commented Sep 9, 2024

The coldcard job (for different python versions) is failling due to the following error:

From CI (e.g https://github.com/bitcoin-core/HWI/actions/runs/10762544360/job/29843131139):

Traceback (most recent call last):
  File "/github/home/.cache/pypoetry/virtualenvs/hwi-crEDFiR--py3.8/lib/python3.8/site-packages/sdl2/dll.py", line 362, in <module>
    dll = DLL("SDL2", ["SDL2", "SDL2-2.0", "SDL2-2.0.0"], os.getenv("PYSDL2_DLL_PATH"))
  File "/github/home/.cache/pypoetry/virtualenvs/hwi-crEDFiR--py3.8/lib/python3.8/site-packages/sdl2/dll.py", line 253, in __init__
    raise RuntimeError("could not find any library for %s (%s)" %
RuntimeError: could not find any library for SDL2 (PYSDL2_DLL_PATH: unset)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "simulator.py", line 20, in <module>
    import sdl2.ext
  File "/github/home/.cache/pypoetry/virtualenvs/hwi-crEDFiR--py3.8/lib/python3.8/site-packages/sdl2/__init__.py", line 2, in <module>
    from .dll import get_dll_file, _bind
  File "/github/home/.cache/pypoetry/virtualenvs/hwi-crEDFiR--py3.8/lib/python3.8/site-packages/sdl2/dll.py", line 364, in <module>
    raise ImportError(exc)
ImportError: could not find any library for SDL2 (PYSDL2_DLL_PATH: unset)
coldcard: test_backup (test_coldcard.TestColdcardManCommands) ...

According to the coldcard documentation (https://github.com/Coldcard/firmware?tab=readme-ov-file#linux), besides running pip install -r requirements.txt, it's required to install pysdl2-dll.

@achow101
Copy link
Member

achow101 commented Sep 9, 2024

Looks like it's still failing https://github.com/bitcoin-core/HWI/actions/runs/10774640633/job/29879492171?pr=756#logs

@brunoerg brunoerg marked this pull request as draft September 9, 2024 16:50
@brunoerg brunoerg force-pushed the 2024-09-fix-coldcard branch from 1eec64d to 7e8bdea Compare September 9, 2024 16:54
@brunoerg
Copy link
Contributor Author

brunoerg commented Sep 9, 2024

Moved to draft to investigate it better. It will need more changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brunoerg @achow101